Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-http): http.url attribute #580

Conversation

OlivierAlbertini
Copy link
Member

closes #579

Short description of the changes

  • add assertion in tests
  • fix copy/paste error

@OlivierAlbertini OlivierAlbertini added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 30, 2019
@OlivierAlbertini OlivierAlbertini force-pushed the feature/typo-url-composition branch 2 times, most recently from f8694cf to c62df3e Compare November 30, 2019 16:16
closes open-telemetry#579

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@codecov-io
Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #580 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #580     +/-   ##
=========================================
+ Coverage   90.43%   90.54%   +0.1%     
=========================================
  Files         154      155      +1     
  Lines        7924     8025    +101     
  Branches      697      703      +6     
=========================================
+ Hits         7166     7266    +100     
- Misses        758      759      +1
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/utils.ts 100% <100%> (ø) ⬆️
...opentelemetry-plugin-http/test/utils/assertSpan.ts 100% <100%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
packages/opentelemetry-plugin-mysql/src/utils.ts 90.9% <0%> (-4.55%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
... and 9 more

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Dec 2, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.3 milestone Dec 2, 2019
@mayurkale22 mayurkale22 merged commit 06d21e3 into open-telemetry:master Dec 2, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…elemetry#580)

* fix: redis instrumentation loses context when using callbacks

* fix: rename test

* fix: merge new test into existing describe

* fix: refactor context.with as requested

* fix: remove redundant callbackThis const

* fix: move originalContext to inside if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin-http] error in getAbsoluteUrl method
5 participants