Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-http): http.url attribute #580

Conversation

@OlivierAlbertini
Copy link
Member

OlivierAlbertini commented Nov 30, 2019

closes #579

Short description of the changes

  • add assertion in tests
  • fix copy/paste error
@OlivierAlbertini OlivierAlbertini force-pushed the OlivierAlbertini:feature/typo-url-composition branch 2 times, most recently from f8694cf to c62df3e Nov 30, 2019
closes #579

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini OlivierAlbertini force-pushed the OlivierAlbertini:feature/typo-url-composition branch from c62df3e to 9773f9c Nov 30, 2019
@OlivierAlbertini OlivierAlbertini marked this pull request as ready for review Nov 30, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 30, 2019

Codecov Report

Merging #580 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #580     +/-   ##
=========================================
+ Coverage   90.43%   90.54%   +0.1%     
=========================================
  Files         154      155      +1     
  Lines        7924     8025    +101     
  Branches      697      703      +6     
=========================================
+ Hits         7166     7266    +100     
- Misses        758      759      +1
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/utils.ts 100% <100%> (ø) ⬆️
...opentelemetry-plugin-http/test/utils/assertSpan.ts 100% <100%> (ø) ⬆️
...kages/opentelemetry-metrics/test/mocks/Exporter.ts 66.66% <0%> (-33.34%) ⬇️
packages/opentelemetry-plugin-mysql/src/utils.ts 90.9% <0%> (-4.55%) ⬇️
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.29% <0%> (-3.71%) ⬇️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
... and 9 more
@obecny
obecny approved these changes Dec 2, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.3 milestone Dec 2, 2019
@mayurkale22 mayurkale22 merged commit 06d21e3 into open-telemetry:master Dec 2, 2019
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.