Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ioredis example #665

Open
wants to merge 6 commits into
base: master
from

Conversation

@naseemkullah
Copy link
Contributor

naseemkullah commented Jan 5, 2020

Which problem is this PR solving?

  • Adds an example for ioredis

Short description of the changes

  • Adds an example for ioredis
@naseemkullah naseemkullah force-pushed the naseemkullah:ioredis-example-2 branch from fff6235 to c0c64f5 Jan 5, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #665 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   91.01%   90.98%   -0.04%     
==========================================
  Files         224      221       -3     
  Lines       10433    10218     -215     
  Branches      962      921      -41     
==========================================
- Hits         9496     9297     -199     
+ Misses        937      921      -16
Impacted Files Coverage Δ
packages/opentelemetry-plugin-https/src/utils.ts 100% <0%> (ø) ⬆️
...ages/opentelemetry-plugin-http/src/enums/Format.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/utils.ts 70% <0%> (ø) ⬆️
...lemetry-plugin-http/test/utils/DummyPropagation.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-dns/src/version.ts 100% <0%> (ø) ⬆️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 33.33% <0%> (ø) ⬆️
...ry-plugin-dns/test/functionals/dns-disable.test.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/BinaryTraceContext.ts 96.72% <0%> (-1.62%) ⬇️
... and 55 more
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 5, 2020

Nothing looks wrong to me here so I'm going to give it an approval, but in the future I think we should make the examples as simple as possible. This one has a client and server aspect to it and a lot of code not dealing specifically with ioredis which can make the ioredis code feel a little lost. I realize the other examples do this too, but there are a lot of examples now with client/server and I think we should simplify them.

Copy link
Member

OlivierAlbertini left a comment

express and axios should be removed

@naseemkullah

This comment has been minimized.

Copy link
Contributor Author

naseemkullah commented Jan 6, 2020

Nothing looks wrong to me here so I'm going to give it an approval, but in the future I think we should make the examples as simple as possible. This one has a client and server aspect to it and a lot of code not dealing specifically with ioredis which can make the ioredis code feel a little lost. I realize the other examples do this too, but there are a lot of examples now with client/server and I think we should simplify them.

I agree. This example is based off of other examples in the repo as you mention but I will adjust it according to your suggestion.

@naseemkullah

This comment has been minimized.

Copy link
Contributor Author

naseemkullah commented Jan 6, 2020

Let's hold off as there is an inherent issue with the ioredis plugin in general as per #668

@naseemkullah

This comment has been minimized.

Copy link
Contributor Author

naseemkullah commented Jan 6, 2020

The example has been simplified.

@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 6, 2020

Adding the hold label since we're waiting on another issue

naseemkullah added 3 commits Jan 8, 2020
@naseemkullah naseemkullah force-pushed the naseemkullah:ioredis-example-2 branch from ec4de16 to aa877f4 Jan 23, 2020
@dyladan

This comment has been minimized.

Copy link
Contributor

dyladan commented Jan 23, 2020

@naseemkullah now that the bug is fixed, is this ready?

- Set EXPORTER variable

```sh
export EXPORTER=zipkin

This comment has been minimized.

Copy link
@dyladan

dyladan Jan 23, 2020

Contributor

Instead of requiring a user to export an environment variable, use cross-env module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.