Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ts-node version to ^8.6.2 #687

Merged
merged 2 commits into from Jan 13, 2020

Conversation

@mayurkale22
Copy link
Member

mayurkale22 commented Jan 13, 2020

Which problem is this PR solving?

Copy link
Contributor

dyladan left a comment

Like that this makes the versions consistent too. Looks like it was all over the place before.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 13, 2020

Codecov Report

Merging #687 into master will decrease coverage by 1.97%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #687      +/-   ##
=========================================
- Coverage   91.58%   89.6%   -1.98%     
=========================================
  Files         217     213       -4     
  Lines       10156   10038     -118     
  Branches      916     931      +15     
=========================================
- Hits         9301    8995     -306     
- Misses        855    1043     +188
Impacted Files Coverage Δ
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
... and 50 more
@mayurkale22 mayurkale22 merged commit 49824c2 into open-telemetry:master Jan 13, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: lint_&_docs Your tests failed on CircleCI
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:ts-node-patch branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.