-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unref jaeger socket to prevent process running indefinitely #715
Merged
dyladan
merged 4 commits into
open-telemetry:master
from
dynatrace-oss-contrib:unref-jaeger
Jan 24, 2020
Merged
fix: unref jaeger socket to prevent process running indefinitely #715
dyladan
merged 4 commits into
open-telemetry:master
from
dynatrace-oss-contrib:unref-jaeger
Jan 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 92.94% 90.95% -1.99%
==========================================
Files 225 226 +1
Lines 10786 10359 -427
Branches 977 955 -22
==========================================
- Hits 10025 9422 -603
- Misses 761 937 +176
|
OlivierAlbertini
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -40,6 +41,11 @@ export class JaegerExporter implements SpanExporter { | |||
typeof config.flushTimeout === 'number' ? config.flushTimeout : 2000; | |||
|
|||
this._sender = new jaegerTypes.UDPSender(config); | |||
if (this._sender._client instanceof Socket) { | |||
// unref socket to prevent it from keeping the process running | |||
this._sender._client.unref(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
mayurkale22
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712