Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add composite propagator #821

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Feb 28, 2020

@dyladan dyladan added the enhancement New feature or request label Feb 28, 2020
@dyladan dyladan added this to the Beta milestone Feb 28, 2020
@dyladan dyladan mentioned this pull request Feb 28, 2020
46 tasks
@codecov-io
Copy link

codecov-io commented Feb 28, 2020

Codecov Report

Merging #821 into master will decrease coverage by 1.44%.
The diff coverage is 97.18%.

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   94.13%   92.68%   -1.45%     
==========================================
  Files         249      247       -2     
  Lines       10751    10997     +246     
  Branches     1028     1071      +43     
==========================================
+ Hits        10120    10193      +73     
- Misses        631      804     +173
Impacted Files Coverage Δ
...elemetry-core/src/context/propagation/composite.ts 100% <100%> (ø)
.../opentelemetry-core/test/context/composite.test.ts 96.36% <96.36%> (ø)
...s/opentelemetry-core/test/context/B3Format.test.ts 50% <0%> (-50%) ⬇️
packages/opentelemetry-core/test/utils/url.test.ts 50% <0%> (-50%) ⬇️
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ckages/opentelemetry-core/test/platform/id.test.ts 66.66% <0%> (-33.34%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
... and 38 more

@mayurkale22
Copy link
Member

Please fix the build

@vmarchaud vmarchaud self-requested a review March 1, 2020 14:34
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dyladan dyladan merged commit 151106a into open-telemetry:master Mar 4, 2020
@dyladan dyladan deleted the composite-propagator branch March 4, 2020 18:52
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants