Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename scope to context #853

Merged
merged 6 commits into from Mar 13, 2020

Conversation

@dyladan
Copy link
Contributor

dyladan commented Mar 12, 2020

Fixes #794

dyladan added 2 commits Mar 12, 2020
Copy link
Member

OlivierAlbertini left a comment

LGTM

@mayurkale22

This comment has been minimized.

Copy link
Member

mayurkale22 commented Mar 13, 2020

Please resolve the conflicts.

@dyladan dyladan added this to the Beta milestone Mar 13, 2020
@obecny
obecny approved these changes Mar 13, 2020
Copy link
Member

obecny left a comment

lots of changes, lgtm, question with regards to 2 files, it seems like 2 of them were nor renamed but deleted and added ?

@@ -0,0 +1,290 @@
/*!

This comment has been minimized.

Copy link
@obecny

obecny Mar 13, 2020

Member

is this a new file ?

This comment has been minimized.

Copy link
@dyladan

dyladan Mar 13, 2020

Author Contributor

It is a moved file but the git change detection isn't smart enough to figure that out because the whole package moved and the name also changed.

@@ -0,0 +1,198 @@
/*!

This comment has been minimized.

Copy link
@obecny

obecny Mar 13, 2020

Member

could you just rename file ?

This comment has been minimized.

Copy link
@dyladan

dyladan Mar 13, 2020

Author Contributor

It is a moved file but the git change detection isn't smart enough.

@dyladan dyladan merged commit 9a3fd7b into open-telemetry:master Mar 13, 2020
7 checks passed
7 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node13 Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation dyladan authorized
Details
@dyladan dyladan deleted the dynatrace-oss-contrib:context-rename branch Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.