Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: Add lastUpdateTimestamp associated with point #893

Merged
merged 6 commits into from
Mar 27, 2020
Merged

Metrics: Add lastUpdateTimestamp associated with point #893

merged 6 commits into from
Mar 27, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Mar 23, 2020 •
edited
Loading

dyladan
dyladan reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok except for the timestamp comment on measure. It also doesn't appear these times are currently used for anything, is that on purpose?

packages/opentelemetry-metrics/src/export/Aggregator.ts Show resolved Hide resolved
@mayurkale22 mayurkale22 marked this pull request as ready for review March 26, 2020 19:59
dyladan
dyladan approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like the timestamps are unused so far, is that intentional?

@mayurkale22
Copy link
Member Author

LGTM. It looks like the timestamps are unused so far, is that intentional?

Used in PrometheusExporter while recording Gauge value : https://github.com/open-telemetry/opentelemetry-js/pull/893/files#diff-7803f704226aa2df8c0c4ca194a4ae9dR150

@dyladan dyladan assigned dyladan and unassigned dyladan Mar 27, 2020
@dyladan dyladan added the enhancement New feature or request label Mar 27, 2020
@codecov-io
Copy link

codecov-io commented Mar 27, 2020 •
edited
Loading

Codecov Report

Merging #893 into master will increase coverage by 27.33%.
The diff coverage is 97.87%.

@@             Coverage Diff             @@
##           master     #893       +/-   ##
===========================================
+ Coverage   66.88%   94.21%   +27.33%     
===========================================
  Files          81      248      +167     
  Lines        1999    11000     +9001     
  Branches      302     1047      +745     
===========================================
+ Hits         1337    10364     +9027     
+ Misses        662      636       -26
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/export/types.ts 100.00% <ø> (ø)
...emetry-metrics/src/export/ConsoleMetricExporter.ts 72.22% <50.00%> (ø)
...pentelemetry-exporter-prometheus/src/prometheus.ts 92.07% <100.00%> (ø)
...ges/opentelemetry-metrics/src/export/Aggregator.ts 100.00% <100.00%> (ø)
packages/opentelemetry-metrics/test/Meter.test.ts 100.00% <100.00%> (ø)
.../opentelemetry-exporter-collector/src/transform.ts 89.74% <0.00%> (-7.44%) ⬇️
packages/opentelemetry-core/src/utils/url.ts 100.00% <0.00%> (ø)
...es/opentelemetry-exporter-collector/test/helper.ts 100.00% <0.00%> (ø)
.../opentelemetry-core/src/trace/spancontext-utils.ts 100.00% <0.00%> (ø)
...opentelemetry-api/src/metrics/NoopMeterProvider.ts 100.00% <0.00%> (ø)
... and 191 more

@dyladan
Copy link
Member

dyladan commented Mar 27, 2020

@open-telemetry/javascript-approvers would like some approvals on this so it can be included in 0.5.2 today if possible.

vmarchaud
vmarchaud approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit 87236cc into open-telemetry:master Mar 27, 2020
@mayurkale22 mayurkale22 deleted the last_update_time branch March 27, 2020 17:00
obecny
obecny approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just jsdoc missing

packages/opentelemetry-metrics/src/export/types.ts
/** Returns snapshot of the current point (value with timestamp). */
toPoint(): Point;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsdoc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will include this in separate PR, thanks for noticing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@bg451 bg451 Awaiting requested review from bg451

@markwolff markwolff Awaiting requested review from markwolff

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mayurkale22 @codecov-io @dyladan @obecny @vmarchaud