Add Logger interface #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
danielkhan,
iredelmeier,
justindsmith and
rochdev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
- Coverage 100% 98.03% -1.97%
==========================================
Files 12 13 +1
Lines 200 204 +4
Branches 8 8
==========================================
Hits 200 200
- Misses 0 4 +4
|
draffensperger
approved these changes
Jul 11, 2019
rochdev
approved these changes
Jul 11, 2019
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
…db-3.x Update dependency @types/mongodb to v3.5.25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains
Loggerinterface andNoopLoggerimplementation.I think we can extend this base interface to add
ConsoleLogger(or somthing else) with config options like logLevel, strictMode(#92) etc.