Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad null check #946

Merged
merged 1 commit into from Apr 8, 2020
Merged

Remove bad null check #946

merged 1 commit into from Apr 8, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 8, 2020

Fixes #945

@dyladan
chore: remove bad null check
644a3dc 
typeof null is 'object'
@dyladan dyladan added the bug Something isn't working label Apr 8, 2020
@dyladan dyladan mentioned this pull request Apr 8, 2020
Closed
@codecov-io
Copy link

codecov-io commented Apr 8, 2020 •
edited

Codecov Report

Merging #946 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #946   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files         248      248           
  Lines       11183    11183           
  Branches     1069     1069           
=======================================
  Hits        10616    10616           
  Misses        567      567
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/utils.ts 97.40% <100.00%> (ø)

@mayurkale22 mayurkale22 merged commit b43ac51 into open-telemetry:master Apr 8, 2020
@dyladan dyladan deleted the header-null-check branch April 8, 2020 18:41
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@rauno56
fix(amqplib): add missing rabbit service to CI daily run (open-teleme…
5f63606 
…try#946)

* fix(amqplib): add missing rabbit service to CI daily run

* ci: don't run amqplib tav on node 8

Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markwolff markwolff markwolff approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@bg451 bg451 Awaiting requested review from bg451

@obecny obecny Awaiting requested review from obecny

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot convert undefined or null to object
4 participants
@dyladan @codecov-io @markwolff @mayurkale22