Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] fix: use url.URL #960

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Conversation

naseemkullah
Copy link
Member

url.URL from the standard library should be used instead of the global URL which comes from the dom lib.

Signed-off-by: Naseem naseem@transit.app

Fixes #938

Seems to be the only two instances of the dom lib URL in both packages.

cc @dyladan @OlivierAlbertini

url.URL from the standard library should be used instead of the global URL which comes from the dom lib.

Signed-off-by: Naseem <naseem@transit.app>
@codecov-io
Copy link

codecov-io commented Apr 12, 2020

Codecov Report

Merging #960 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master     #960    +/-   ##
========================================
  Coverage   94.79%   94.80%            
========================================
  Files         259      254     -5     
  Lines       11590    11393   -197     
  Branches     1096     1081    -15     
========================================
- Hits        10987    10801   -186     
+ Misses        603      592    -11     
Impacted Files Coverage Δ
packages/opentelemetry-plugin-http/src/http.ts 97.57% <ø> (ø)
packages/opentelemetry-plugin-redis/src/enums.ts
packages/opentelemetry-plugin-redis/src/utils.ts
packages/opentelemetry-plugin-redis/src/version.ts
...ages/opentelemetry-plugin-redis/test/redis.test.ts
packages/opentelemetry-plugin-redis/src/redis.ts

@mayurkale22 mayurkale22 merged commit 1959930 into open-telemetry:master Apr 16, 2020
@naseemkullah naseemkullah deleted the http-url branch April 16, 2020 22:03
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use url.URL in http and https plugins
5 participants