fix(http-plugin): strip otel custom http header #983 #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini and
rochdev
as code owners
vmarchaud
added
the
size/S
dyladan
reviewed
Apr 27, 2020
|
Who removes the header in case http plugin is disabled? |
Nobody. If this is important, maybe we should switch to use a hidden property on the request then? Or we could just wait for open-telemetry/opentelemetry-specification#530 I don't really like that we use header values as a signal between plugins. It is an observable side-effect, and quite an intrusive one at that. I much prefer the idea to use context to stop tracing. |
vmarchaud
force-pushed
the
strip-otel-http-header
branch
from
65988bd
to
da78f3e
Compare
dyladan
approved these changes
May 6, 2020
markwolff
approved these changes
May 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 212 212
Lines 8895 8899 +4
Branches 801 800 -1
=======================================
+ Hits 8462 8466 +4
Misses 433 433
|
mayurkale22
approved these changes
May 7, 2020
vmarchaud
force-pushed
the
strip-otel-http-header
branch
from
3235a97
to
5b9e397
Compare
dyladan
approved these changes
May 11, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: use Otel SDK 1.2/0.28 * fixup! chore(deps): update dependency @types/react-dom to v18 (open-telemetry#974) * host-metrics back to 0.27 * fix: correctly depen on contrib-test-utils * fixup! fix: correctly depen on contrib-test-utils * fixup! feat: use Otel SDK 1.2/0.28
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
* feat: use Otel SDK 1.2/0.28 * fixup! chore(deps): update dependency @types/react-dom to v18 (open-telemetry#974) * host-metrics back to 0.27 * fix: correctly depen on contrib-test-utils * fixup! fix: correctly depen on contrib-test-utils * fixup! feat: use Otel SDK 1.2/0.28
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 16, 2024
* feat: use Otel SDK 1.2/0.28 * fixup! chore(deps): update dependency @types/react-dom to v18 (open-telemetry#974) * host-metrics back to 0.27 * fix: correctly depen on contrib-test-utils * fixup! fix: correctly depen on contrib-test-utils * fixup! feat: use Otel SDK 1.2/0.28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #983 and #965 (comment) for context