fix(opentracing-shim): update opentracing shim example #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update initialisation of OpenTracing GlobalTracer in opentracing shim example. A previous update had modified to this to incorrectly use a set method that does not exist on that API.
sleighzy
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 210 210
Lines 8571 8571
Branches 772 772
=======================================
Hits 8139 8139
Misses 432 432 |
dyladan
approved these changes
Apr 28, 2020
mayurkale22
approved these changes
Apr 28, 2020
vmarchaud
approved these changes
Apr 29, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Gerhard Stöbich <deb2001-github@yahoo.de> Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
A previous update to the opentracing-shim example had modified to this to incorrectly use a setter method to set the global tracer. A similar method exists on the OpenTelemetry API but not the OpenTracing API. This was causing JavaScript errors when attempting to run the example.
Short description of the changes
Update to call the correct method on the OpenTracing API to initialise the global tracer.
Fixes #988