Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[target-allocator] Target-level metadata labels is lost #948

Closed
CoderPoet opened this issue Jun 26, 2022 · 1 comment
Closed

[target-allocator] Target-level metadata labels is lost #948

CoderPoet opened this issue Jun 26, 2022 · 1 comment
Labels
area:target-allocator Issues for target-allocator

Comments

@CoderPoet
Copy link
Contributor

When we use the target discovery of prometheus, we can only get the outermost metadata Labels, and lose the metadata Labels of the Targ-level

Tc7tyfWAne

nXVEwRXuwh

Expect to be able to get metadata to the Target-level Labels

4xYSq4cbTF
CoderPoet added a commit to CoderPoet/opentelemetry-operator that referenced this issue Jun 26, 2022
@CoderPoet
Fix the issue that target-level metadata labels were missing (open-te…
295c821 
…lemetry#948)
CoderPoet added a commit to CoderPoet/opentelemetry-operator that referenced this issue Jun 26, 2022
@CoderPoet
Fix the issue that target-level metadata labels were missing (open-te…
bf9fbec 
…lemetry#948)
CoderPoet added a commit to CoderPoet/opentelemetry-operator that referenced this issue Jun 27, 2022
@CoderPoet
Fix the issue that target-level metadata labels were missing (open-te…
a3db84e 
…lemetry#948)
@pavolloffay pavolloffay added the area:target-allocator Issues for target-allocator label Jul 20, 2022
@jaronoff97 jaronoff97 mentioned this issue Jul 26, 2022
Closed
jpkrohling pushed a commit that referenced this issue Jul 26, 2022
@CoderPoet
Fix the issue that target-level metadata labels were missing (#948) (#…
ab00e8c 
…949)

* Fix the issue that target-level metadata labels were missing (#948)

* fix(allocation): GetAllTargetsByCollectorAndJob with label merge
@secustor
Copy link
Member

secustor commented Nov 3, 2022

This should be fixed with #949

@secustor secustor closed this as completed Nov 3, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this issue May 1, 2024
@CoderPoet
Fix the issue that target-level metadata labels were missing (open-te…
66611e4 
…lemetry#948) (open-telemetry#949)

* Fix the issue that target-level metadata labels were missing (open-telemetry#948)

* fix(allocation): GetAllTargetsByCollectorAndJob with label merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:target-allocator Issues for target-allocator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pavolloffay @secustor @CoderPoet