Allow setting of PDB for per-node #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
approved these changes
May 8, 2024
|
Thanks @jaronoff97 ... I appreciate the change. I still don't actually think there should be controls on whether or not I am allowed to define a PDB, but at least this will help us solve the issue we were running into! :) |
|
@diranged you're always able to define a PDB outside what the operator provides :) this is for the user convenience for something within the bounds of what we know will work. I'd be happy to review a follow up / discuss further during our next sig call! |
iblancasa
approved these changes
May 23, 2024
matej-g
approved these changes
Jun 13, 2024
swiatekm
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Makes it possible to set PDBs for per-node strategy
Link to tracking Issue(s):
resolves #2900
Testing: unit tests added
Documentation: n/a