adding macos build (#143)

* adding macos build

* remove extra parenthesis

* test more php versions against macos

* fixing codeowners to be group-based

.github/workflows/build.yml

@@ -32,6 +32,33 @@ jobs:
             TEST_PHP_ARGS: "-q" #do not try to submit failures
           run: make test TESTS=--show-diff
 
+  macos:
+    runs-on: macos-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ '8.0', '8.1', '8.2', '8.3' ]
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+
+      - name: build
+        run: |
+          phpize
+          ./configure
+          make
+
+      - name: test
+        env:
+          TEST_PHP_ARGS: "-q" #do not try to submit failures
+        run: make test TESTS=--show-diff
+
   pecl-package:
     runs-on: ubuntu-latest
     container:

CODEOWNERS

@@ -12,4 +12,4 @@
 #  https://help.github.com/en/articles/about-code-owners
 #
 
-* @bobstrecansky @brettmc @pdelewski
+* @open-telemetry/php-approvers

ext/otel_observer.c

@@ -228,7 +228,7 @@ static inline bool is_valid_signature(zend_fcall_info fci,
         zval param = fci.params[i];
         type = Z_TYPE(fci.params[i]);
 
-        if ((type_mask == IS_UNDEF)) {
+        if (type_mask == IS_UNDEF) {
             // no type mask -> ok
         } else if (Z_TYPE(param) == IS_OBJECT) {
             // object special-case handling (check for interfaces, subclasses)