Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding macos build #143

Merged
merged 4 commits into from
Apr 30, 2024
Merged

adding macos build #143

merged 4 commits into from
Apr 30, 2024

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Apr 27, 2024 •
edited
Loading

  • adding macos to github actions
  • fix a clang warning that stops compilation on macos
  • fixing codeowners to be group-based

Fixes: open-telemetry/opentelemetry-php#1283

@brettmc brettmc marked this pull request as ready for review April 27, 2024 04:30
@brettmc
Copy link
Collaborator Author

brettmc commented Apr 27, 2024

Note in run https://github.com/open-telemetry/opentelemetry-php-instrumentation/actions/runs/8857254849/job/24324517256 that it failed on the issue reported in the linked issue, which I subsequently fixed.

@bobstrecansky bobstrecansky merged commit 967dec0 into open-telemetry:main Apr 30, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobstrecansky bobstrecansky bobstrecansky approved these changes

@ChrisLightfootWild ChrisLightfootWild ChrisLightfootWild approved these changes

@pdelewski pdelewski Awaiting requested review from pdelewski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brettmc @bobstrecansky @ChrisLightfootWild