Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize protobuf enums as integer #1192

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Dec 15, 2023

Workaround for #978, traverses the serialized json payload and replaces every enum value with its respective numeric value.

Spec: "Values of enum fields MUST be encoded as integer values."
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #1192 (1656be1) into main (d376566) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1192      +/-   ##
============================================
- Coverage     84.29%   83.90%   -0.39%     
- Complexity     2196     2208      +12     
============================================
  Files           282      282              
  Lines          6245     6274      +29     
============================================
  Hits           5264     5264              
- Misses          981     1010      +29     
Flag Coverage Δ
7.4 82.55% <0.00%> (-0.39%) ⬇️
8.0 83.83% <0.00%> (-0.39%) ⬇️
8.1 83.96% <0.00%> (-0.40%) ⬇️
8.2 83.96% <0.00%> (-0.40%) ⬇️
8.3 83.96% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Contrib/Otlp/ProtobufSerializer.php 17.33% <0.00%> (-10.93%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d376566...1656be1. Read the comment docs.

@Nevay Nevay marked this pull request as ready for review December 15, 2023 11:04
@Nevay Nevay requested a review from a team as a code owner December 15, 2023 11:04
@brettmc brettmc merged commit d414999 into open-telemetry:main Dec 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants