-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span processor exporter updates #439
Merged
bobstrecansky
merged 4 commits into
open-telemetry:main
from
Blacksmoke16:span-processor-exporter-updates
Oct 9, 2021
Merged
Span processor exporter updates #439
bobstrecansky
merged 4 commits into
open-telemetry:main
from
Blacksmoke16:span-processor-exporter-updates
Oct 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `Exporter` to `SpanExporterInterface` Update docs to include links to spec
Revamp `SimpleSpanProcessorTest`
Blacksmoke16
commented
Oct 7, 2021
Blacksmoke16
commented
Oct 7, 2021
Codecov Report
@@ Coverage Diff @@
## main #439 +/- ##
============================================
- Coverage 92.84% 91.14% -1.70%
- Complexity 781 804 +23
============================================
Files 74 76 +2
Lines 1929 1977 +48
============================================
+ Hits 1791 1802 +11
- Misses 138 175 +37
Continue to review full report at Codecov.
|
Blacksmoke16
commented
Oct 7, 2021
This was referenced Oct 9, 2021
Closed
Blacksmoke16
requested review from
beniamin,
bobstrecansky and
zsistla
as code owners
October 9, 2021 01:33
bobstrecansky
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exporter
toSpanExporterInterface
shutdown
andforceFlush
methods to returnbool
NoopTracer
andNoopSpanBuilder
#getTracer
on a shutdownTracerProvider
#shutdown
also calls#forceFlush
as per the specSpanMultiProcessor
toMultiSpanProcessor
to better match naming of other processorsTODO:
Resolves #270