Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace E_USER_NOTICE with E_USER_DEPRECATED #647

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

ivoba
Copy link
Contributor

@ivoba ivoba commented Mar 31, 2022

Since it is a notice about a deprecation it should also use E_USER_DEPRECATED as log level.
NOTICE seems to be not the appropriate log level.

In my case it broke the application in dev mode where Notices are considered errors.

@welcome
Copy link

welcome bot commented Mar 31, 2022

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ivoba / name: Ivo Bathke (3bd4143)

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #647 (e2d6213) into main (e62cd5e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #647      +/-   ##
============================================
- Coverage     84.45%   84.45%   -0.01%     
  Complexity     1141     1141              
============================================
  Files           127      127              
  Lines          2767     2766       -1     
============================================
- Hits           2337     2336       -1     
  Misses          430      430              
Flag Coverage Δ
7.4 84.40% <100.00%> (-0.01%) ⬇️
8.0 84.45% <100.00%> (-0.01%) ⬇️
8.1 84.45% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Dev/Compatibility/Util.php 100.00% <100.00%> (ø)
src/Contrib/Jaeger/IdConverter.php 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e62cd5e...e2d6213. Read the comment docs.

@bobstrecansky bobstrecansky merged commit 72816bb into open-telemetry:main Apr 2, 2022
brettmc added a commit that referenced this pull request Apr 3, 2022
brettmc added a commit that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants