Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "replace E_USER_NOTICE with E_USER_DEPRECATED" #655

Merged
merged 1 commit into from
Apr 3, 2022

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Apr 3, 2022

Reverts #647
We were discussing this PR internally, and think that the original behaviour was correct and intentional - the BC layer is for the protection of code running in production mode, but not development mode.

@brettmc
Copy link
Collaborator Author

brettmc commented Apr 3, 2022

@ivoba - you can catch one of us on slack if you'd like more details :)

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #655 (a7fb42c) into main (72816bb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #655   +/-   ##
=========================================
  Coverage     84.27%   84.27%           
  Complexity     1146     1146           
=========================================
  Files           127      127           
  Lines          2772     2772           
=========================================
  Hits           2336     2336           
  Misses          436      436           
Flag Coverage Δ
7.4 84.21% <100.00%> (ø)
8.0 84.27% <100.00%> (ø)
8.1 84.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/SDK/Common/Dev/Compatibility/Util.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72816bb...a7fb42c. Read the comment docs.

@brettmc brettmc merged commit e096e52 into main Apr 3, 2022
@brettmc brettmc deleted the revert-647-depreaction-notices branch April 3, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants