Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Is TraceConfig still relevant? #410

Closed
b-viguier opened this issue Jun 28, 2022 · 0 comments 路 Fixed by #411
Closed

[Doc] Is TraceConfig still relevant? #410

b-viguier opened this issue Jun 28, 2022 · 0 comments 路 Fixed by #411

Comments

@b-viguier
Copy link

Hello 馃憢 馃檪

Although I find the TraceConfig resource very interesting, I can't find any concrete usage in the documentation, nor in the protocol...

Is it still relevant? Should it be discarded? Or is it part of a future improvement?

Thanks for your work 馃檱

tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue Jul 4, 2022
Resolves open-telemetry#410

I am not aware of any OpenTelemetry or non-OpenTelemetry
codebase that uses the experimental TraceConfig.

I suggest to remove it. It can be added back if we see the
need for it in the future.

The SDK configuration may also be achieved by different means,
see open-telemetry/opentelemetry-specification#2207

We need to keep this PR open for a while and circulate it widely
to make sure we give enough opportunity to object the removal.
tigrannajaryan added a commit that referenced this issue Jul 20, 2022
Resolves #410

I am not aware of any OpenTelemetry or non-OpenTelemetry
codebase that uses the experimental TraceConfig.

I suggest to remove it. It can be added back if we see the
need for it in the future.

The SDK configuration may also be achieved by different means,
see open-telemetry/opentelemetry-specification#2207

We need to keep this PR open for a while and circulate it widely
to make sure we give enough opportunity to object the removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant