Delete unused experimental TraceConfig #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves open-telemetry#410 I am not aware of any OpenTelemetry or non-OpenTelemetry codebase that uses the experimental TraceConfig. I suggest to remove it. It can be added back if we see the need for it in the future. The SDK configuration may also be achieved by different means, see open-telemetry/opentelemetry-specification#2207 We need to keep this PR open for a while and circulate it widely to make sure we give enough opportunity to object the removal.
arminru
approved these changes
Jul 4, 2022
jack-berg
approved these changes
Jul 5, 2022
carlosalberto
approved these changes
Jul 5, 2022
blumamir
approved these changes
Jul 5, 2022
Aneurysm9
approved these changes
Jul 5, 2022
jsuereth
approved these changes
Jul 8, 2022
WenheLI
added a commit
to WenheLI/opentelemetry-proto
that referenced
this pull request
Jul 20, 2022
This reverts commit 157bedf.
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 12, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 13, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * opentelemetry-stackdriver: Ignore check for update to date. ** Outside the scope of this change. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
hdost
added a commit
to hdost/opentelemetry-rust
that referenced
this pull request
Mar 13, 2023
* Update the generated files. * Remove trace_config.rs open-telemetry/opentelemetry-proto#411 * InstrumentationLibary -> InstrumentationScope * TODO: Update in the SDK. * InstrumentationLibarySpans -> ScopeSpans * TODO: Update in the SDK. * Implement Min and Max to support export via OTLP. * Remove unused import (causing test failures) Fixes open-telemetry#989 Signed-off-by: Harold Dost <h.dost@criteo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #410
I am not aware of any OpenTelemetry or non-OpenTelemetry
codebase that uses the experimental TraceConfig.
I suggest to remove it. It can be added back if we see the
need for it in the future.
The SDK configuration may also be achieved by different means,
see open-telemetry/opentelemetry-specification#2207
We need to keep this PR open for a while and circulate it widely
to make sure we give enough opportunity to object the removal.