Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum element naming consistency #473

Closed
Tracked by #456
tigrannajaryan opened this issue May 11, 2023 · 1 comment · Fixed by #474
Closed
Tracked by #456

Enum element naming consistency #473

tigrannajaryan opened this issue May 11, 2023 · 1 comment · Fixed by #474

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented May 11, 2023 •
edited

Most of the enum element names are prefixed by enum name in CAPITAL_CASE, e.g.:

enum StatusCode -> element STATUS_CODE_OK

We have 2 enums that don't follow this rule: LogRecordFlags and DataPointFlags.

Should we fix this?

Need to resolve this for 1.0.
This was referenced May 11, 2023
Merged
Closed
@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-approvers If we fix this we will break some existing code. We are formally allowed to do that but it is still an annoyance. What do you think, is it worth it?

tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue May 15, 2023
@tigrannajaryan
Fix LogRecordFlags and DataPointFlags enum element name inconsistency
bad1534 
Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE.

This change makes naming of LogRecordFlags and DataPointFlags elements consistent
with the rest of the enums.

Resolves open-telemetry#473
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-proto that referenced this issue May 15, 2023
@tigrannajaryan
Fix LogRecordFlags and DataPointFlags enum element name inconsistency
3e4505d 
Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE.

This change makes naming of LogRecordFlags and DataPointFlags elements consistent
with the rest of the enums.

Resolves open-telemetry#473
@tigrannajaryan tigrannajaryan mentioned this issue May 15, 2023
Merged
bogdandrutu added a commit that referenced this issue May 20, 2023
@tigrannajaryan @bogdandrutu
Fix LogRecordFlags and DataPointFlags enum element name inconsistency (…
449a1b0 
…#474)

Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE.

This change makes naming of LogRecordFlags and DataPointFlags elements consistent
with the rest of the enums.

Resolves #473

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tigrannajaryan