Fix LogRecordFlags and DataPointFlags enum element name inconsistency #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE. This change makes naming of LogRecordFlags and DataPointFlags elements consistent with the rest of the enums. Resolves open-telemetry#473
Since this is such a high bar should we set some deadline so it doesn't sit forever? There may be TC members who don't feel strongly enough to block it but also don't want to approve it. |
tedsuo
approved these changes
May 16, 2023
jack-berg
approved these changes
May 17, 2023
MrAlias
approved these changes
May 17, 2023
carlosalberto
approved these changes
May 17, 2023
jsuereth
approved these changes
May 17, 2023
jsuereth
approved these changes
May 17, 2023
bogdandrutu
approved these changes
May 17, 2023
jmacd
approved these changes
May 17, 2023
|
We have enough approvals. I am going to keep it open for another day (2 day rule) and then will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other enum element names in this repo are prefixed by enum name in CAPITAL_CASE.
This change makes naming of LogRecordFlags and DataPointFlags elements consistent with the rest of the enums.
Resolves #473
@open-telemetry/specs-approvers this breaks generated code. We are allowed to make such breaking changes, but I want us to be aware that we are causing some pain and only make this change if we think it is worth it. I would want to see a majority of TC approving this before I merge. I can personally argue both ways and do not see the definite argument to make up my mind.