Use trace_state instead of tracestate #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
arminru,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
tigrannajaryan
approved these changes
Mar 10, 2020
reyang
approved these changes
Mar 10, 2020
Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
| @@ -67,7 +67,7 @@ message Span { | |||
| // tracestate conveys information about request position in multiple distributed tracing graphs. | |||
| // It is a tracestate in w3c-trace-context format: https://www.w3.org/TR/trace-context/#tracestate-header | |||
| // See also https://github.com/w3c/distributed-tracing for more details about this field. | |||
| string tracestate = 3; | |||
| string trace_state = 3; | |||
There was a problem hiding this comment.
I'm confused. We intentionally made it a single word in W3C to avoid choosing the separator between words. Can we revert this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to confirm with almost all the languages that use
TraceStateand notTracestate.