Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we revert tracestate -> trace_state rename? #130

Closed
SergeyKanzhelev opened this issue Mar 16, 2020 · 2 comments
Closed

Should we revert tracestate -> trace_state rename? #130

SergeyKanzhelev opened this issue Mar 16, 2020 · 2 comments

Comments

@SergeyKanzhelev
Copy link
Member

See comment here: https://github.com/open-telemetry/opentelemetry-proto/pull/120/files#r393369691
@Oberon00
Copy link
Member

Please see #128: I wouldn't do such renamings anymore now. Also I think the motivation for W3C was to be compatible with protocols other than HTTP. This does not apply to protobuf field names.

@Oberon00 Oberon00 mentioned this issue Mar 17, 2020
Merged
@bogdandrutu
Copy link
Member

I would suggest to not do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Oberon00 @bogdandrutu @SergeyKanzhelev