Remove wrapping of int and double value from SummaryValue message #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
bogdandrutu
reviewed
Nov 12, 2019
tigrannajaryan
force-pushed
the
feature/tigran/remove_summaryvalue_wrapping
branch
from
c743be3
to
743debb
Compare
yurishkuro
reviewed
Nov 14, 2019
tigrannajaryan
force-pushed
the
feature/tigran/remove_summaryvalue_wrapping
branch
2 times, most recently
from
9fe1588
to
db158f2
Compare
bogdandrutu
approved these changes
Nov 14, 2019
lizthegrey
approved these changes
Nov 14, 2019
tigrannajaryan
force-pushed
the
feature/tigran/remove_summaryvalue_wrapping
branch
from
db158f2
to
09cfc16
Compare
bogdandrutu
approved these changes
Nov 14, 2019
jmacd
approved these changes
Nov 15, 2019
jmacd
approved these changes
Nov 15, 2019
tigrannajaryan
force-pushed
the
feature/tigran/remove_summaryvalue_wrapping
branch
2 times, most recently
from
e1dbc26
to
5ae7025
Compare
This micro-optimization reduces CPU and memory usage. ``` goos: darwin goarch: amd64 pkg: github.com/tigrannajaryan/exp-otelproto/encodings BenchmarkEncode/Baseline/Metric/Summary-8 120 50042473 ns/op BenchmarkEncode/Proposed/Metric/Summary-8 136 43423088 ns/op BenchmarkEncode/Baseline/Metric/Mix-8 28 206595979 ns/op BenchmarkEncode/Proposed/Metric/Mix-8 30 199870715 ns/op BenchmarkEncode/Baseline/Metric/MixSeries-8 9 592705353 ns/op BenchmarkEncode/Proposed/Metric/MixSeries-8 10 539199628 ns/op BenchmarkDecode/Baseline/Metric/Summary-8 51 119929790 ns/op 78696041 B/op 2024000 allocs/op BenchmarkDecode/Proposed/Metric/Summary-8 56 104306363 ns/op 69096032 B/op 1824000 allocs/op BenchmarkDecode/Baseline/Metric/Mix-8 10 545856843 ns/op 328040062 B/op 9126000 allocs/op BenchmarkDecode/Proposed/Metric/Mix-8 10 526862286 ns/op 318440044 B/op 8926000 allocs/op BenchmarkDecode/Baseline/Metric/MixSeries-8 5 1161078696 ns/op 752040067 B/op 17626000 allocs/op BenchmarkDecode/Proposed/Metric/MixSeries-8 5 1075300086 ns/op 704040064 B/op 16626000 allocs/op ```
tigrannajaryan
force-pushed
the
feature/tigran/remove_summaryvalue_wrapping
branch
from
5ae7025
to
e5a9d23
Compare
tigrannajaryan
deleted the
feature/tigran/remove_summaryvalue_wrapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This micro-optimization reduces CPU and memory usage.