Skip to content

Commit

Permalink
Fix expected URL in aiohttp instrumentation test (#1772)
Browse files Browse the repository at this point in the history
* WIP

* Revert "WIP"

This reverts commit 3ed4663.

* Fix expected URL in aiohttp instrumentation test

The underlying cause of the issue here is the update of the yarl package
from 1.8.2 to 1.9.1. yarl is used as a dependency in the
opentelemetry-instrumentation-aiohttp package but it is not there where
the issue happens, but in aiohttp who also has yarl as a dependency.

This is why the fix does not touch any relevant part of any
opentelemetry-* code, since it is the return value of aiohttp code who
now has a different value for the URL.

Fixes #1770
  • Loading branch information
ocelotl committed Apr 25, 2023
1 parent 19fe771 commit 5117098
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def test_status_codes(self):
(span_status, None),
{
SpanAttributes.HTTP_METHOD: "GET",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path?query=param#foobar",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path#foobar",
SpanAttributes.HTTP_STATUS_CODE: int(
status_code
),
Expand Down

0 comments on commit 5117098

Please sign in to comment.