Add more features for adding HTTP request / response headers to spans. #1184
Labels
Comments
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Aug 30, 2022
8 tasks
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Aug 30, 2022
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Aug 30, 2022
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Sep 12, 2022
srikanthccv
pushed a commit
that referenced
this issue
Sep 13, 2022
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Sep 14, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for "all" keyword. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner.
10 tasks
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Sep 16, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for "all" keyword. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner.
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Oct 17, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner.
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Oct 17, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner.
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Oct 17, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner. Move TestCustomHeaders to a separate file to avoid module length error.
rogersd
pushed a commit
to rogersd/opentelemetry-python-contrib
that referenced
this issue
Oct 17, 2022
… in ASGI. Next part of open-telemetry#1184 Details: Add test cases for regular expression matching. Add test cases for header sanitizing. Add documentation for regular expression matching and header sanitation. Various documentation cleanups and standardization. Fix keys() in class ASGIGetter so it returns the HTTP header keys instead of a list of available request data. This makes it consistent with the WSGIGetter keys() method. Make ASGIGetter.get() compare all keys in a case insensitive manner. Move TestCustomHeaders to a separate file to avoid module length error.
This was referenced Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I already have #1172 open for this, and I'll be breaking it in to smaller pieces at @lzchen 's request.
Is your feature request related to a problem?
Currently, you can only provide a list of full HTTP request / response header names to be added to the span.
There is also no capacity for header value redaction.
Describe the solution you'd like
It would be nice to be able to specify a regex or "all" to get all headers.
Header value redaction is also a must-have for us.
Describe alternatives you've considered
I considered doing this in my application, but it makes more sense to add it here.
The text was updated successfully, but these errors were encountered: