Add Redis instrumentation query sanitization

[tombruijn]

Description

Add a query sanitizer to the Redis instrumentation. This can be disabled
with the sanitize_query = False config option.

Given the query SET key value, the sanitized query becomes SET ? ?.
Both the keys and values are sanitized, as both can contain PII data.

The Redis queries are sanitized by default. This changes the default
behavior of this instrumentation. Previously it reported unsanitized
Redis queries.

This was previously discussed in the previous implementation of this PR
in PR #1571

Closes #1548

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• tox -e test-instrumentation-redis

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[avzis]

this looks great,
will solve #1548

[tombruijn]

I fixed the lint issue that failed the build previously. I couldn't get the linter to run locally first, but I confirmed it now passes locally.

[shalevr]

I'm not sure why to change the default behavior,
you need to update the test here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
and other users have to change their code too or get different results than expected

[tombruijn]

I'm not sure why to change the default behavior,

This was briefly discussed in the previous implementation of this, in PR #1571.

I think sanitizing the query is a good default. It's better because users won't send any Personal Identifying Information by default, and need to explicitly enable full query reporting if they really need it.

you need to update the test here https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/tests/opentelemetry-docker-tests/tests/redis/test_redis_functional.py
and other users have to change their code too or get different results than expected

Okay, sounds good. I'm just running into another issue where I can't run this test suite. I'm getting connection issues for something. I'll have a look.

[tombruijn]

@shalevr I've updated the functional tests, added new tests to test sanitize_query=False and made sure the db.statement is not longer than 1000 chars. Let me know what you think.

[tombruijn]

@srikanthccv with the discussion about query sanitization by default ongoing in the spec repo, shall I change this PR to not sanitize the queries by default, but make the option available to sanitize query opt-in?
Then we can merge this PR at least.

[srikanthccv]

Yes, please do.

[tombruijn]

@srikanthccv I've changed the sanitize_query config option to be False by default and resolved the merge conflict with the main branch. Can you retry the build? (I ran the tests, black and flake8 locally, so they should be good.)

[tombruijn]

@srikanthccv I pushed the fix for pylint issue.

I really hope it works now. I just cannot get it to fully run all linters locally. Works!