-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Redis instrumentation query sanitization #1572
Add Redis instrumentation query sanitization #1572
Commits on Jan 10, 2023
-
Add Redis instrumentation query sanitization
Add a query sanitizer to the Redis instrumentation. This can be disabled with the `sanitize_query = False` config option. Given the query `SET key value`, the sanitized query becomes `SET ? ?`. Both the keys and values are sanitized, as both can contain PII data. The Redis queries are sanitized by default. This changes the default behavior of this instrumentation. Previously it reported unsanitized Redis queries. This was previously discussed in the previous implementation of this PR in PR open-telemetry#1571 Closes open-telemetry#1548
Configuration menu - View commit details
-
Copy full SHA for 6bbcc99 - Browse repository at this point
Copy the full SHA 6bbcc99View commit details
Commits on Jan 11, 2023
-
Update Redis sanitize_query option documentation
Changes suggested in open-telemetry#1572 (comment)
Configuration menu - View commit details
-
Copy full SHA for f62d6e3 - Browse repository at this point
Copy the full SHA f62d6e3View commit details -
Remove uninstrument & instrument from test setup
The Redis test that performs the tests with the default options, doesn't need to uninstrument and then instrument the instrumentor. This commit removes the unnecessary setup code. The setup code is already present at the top of the file.
Configuration menu - View commit details
-
Copy full SHA for c54e64b - Browse repository at this point
Copy the full SHA c54e64bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48a5eeb - Browse repository at this point
Copy the full SHA 48a5eebView commit details -
Configuration menu - View commit details
-
Copy full SHA for af4957e - Browse repository at this point
Copy the full SHA af4957eView commit details
Commits on Jan 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8462981 - Browse repository at this point
Copy the full SHA 8462981View commit details
Commits on Jan 16, 2023
-
- Update the sanitizer to also account for a max `db.statement` attribute value length. No longer than 1000 characters. - Update the functional tests to assume the queries are sanitized by default. - Add new tests that test the behavior with sanitization turned off. Only for the tests in the first test class. I don't think it's needed to duplicate this test for the clustered and async setup combinations.
Configuration menu - View commit details
-
Copy full SHA for 8d56c2f - Browse repository at this point
Copy the full SHA 8d56c2fView commit details
Commits on Jan 17, 2023
-
Test Redis unsanitized queries by default
Change the Redis functional tests so that they test the unsanitized query by default, and test the sanitized query results in the separate test functions. This is a partial revert of the previous commit 8d56c2f
Configuration menu - View commit details
-
Copy full SHA for 29041f7 - Browse repository at this point
Copy the full SHA 29041f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcc34c1 - Browse repository at this point
Copy the full SHA dcc34c1View commit details
Commits on Jan 25, 2023
-
Disable Redis query sanitization by default
Update the Redis instrumentation library to not change the default behavior for the Redis instrumentation. This can be enabled at a later time when the spec discussion about this topic has concluded. open-telemetry/opentelemetry-specification#3104
Configuration menu - View commit details
-
Copy full SHA for 5fc865f - Browse repository at this point
Copy the full SHA 5fc865fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b192c31 - Browse repository at this point
Copy the full SHA b192c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae2cbd - Browse repository at this point
Copy the full SHA bae2cbdView commit details
Commits on Feb 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 84eff3d - Browse repository at this point
Copy the full SHA 84eff3dView commit details -
Update changelog about Redis query sanitization default
[ci skip] Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f17ccd7 - Browse repository at this point
Copy the full SHA f17ccd7View commit details -
Fix potential error on Redis args being 0
Check the length of the args array and return an empty string if there are no args. That way it won't cause an IndexError if the args array is empty and it tries to fetch the first element, which should be the Redis command.
Configuration menu - View commit details
-
Copy full SHA for 0d712d2 - Browse repository at this point
Copy the full SHA 0d712d2View commit details
Commits on Feb 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ead8771 - Browse repository at this point
Copy the full SHA ead8771View commit details