Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some environments to 3.10 #1604

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Update some environments to 3.10 #1604

merged 1 commit into from
Jan 27, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jan 27, 2023

Fixes #1603

@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 27, 2023
@ocelotl ocelotl self-assigned this Jan 27, 2023
@ocelotl ocelotl requested a review from a team as a code owner January 27, 2023 19:43
@ocelotl
Copy link
Contributor Author

ocelotl commented Jan 27, 2023

@tombruijn

@srikanthccv srikanthccv merged commit a300d65 into main Jan 27, 2023
@tombruijn
Copy link
Contributor

Thank you @ocelotl! This fixed the linter locally for me.

@tombruijn tombruijn mentioned this pull request Jan 30, 2023
Merged
6 tasks
tombruijn added a commit to tombruijn/opentelemetry-python-contrib that referenced this pull request Jan 30, 2023
@tombruijn
Fix install of Python 3.10 on GitHub Actions
08e4536 
In PR open-telemetry#1604 the Python version was upgraded to Python 3.10 to fix a
local issue on M1 MacBooks.

The GitHub Action workflows now exit with the following message for the
docker-tests, spellcheck and lint checks, skipping these checks.

```
lint create: /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  lint: InterpreterNotFound: python3.10
  congratulations :)
```

Upgrade the Python version in the GitHub Actions workflow to fix this.
@tombruijn tombruijn mentioned this pull request Jan 30, 2023
Merged
4 tasks
srikanthccv added a commit that referenced this pull request Feb 3, 2023
@tombruijn @srikanthccv
Fix install of Python 3.10 on GitHub Actions (#1609)
78874df 
* Fix install of Python 3.10 on GitHub Actions

In PR #1604 the Python version was upgraded to Python 3.10 to fix a
local issue on M1 MacBooks.

The GitHub Action workflows now exit with the following message for the
docker-tests, spellcheck and lint checks, skipping these checks.

```
lint create: /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  lint: InterpreterNotFound: python3.10
  congratulations :)
```

Upgrade the Python version in the GitHub Actions workflow to fix this.

* Fix YAML interpretation of Python 3.10

* Upgrade Docker tests dependencies

Upgrade the asyncpg and psycopg2 packages, they don't work on Python
3.10.

This also fixes running these tests no M1 MacBooks.

* Fix linter issues merged into main

They went unnoticed while the CI didn't fail on the lint task not
working.

---------

Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lint and other environments to 3.10
3 participants
@ocelotl @tombruijn @srikanthccv