Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install of Python 3.10 on GitHub Actions #1609

Merged
merged 5 commits into from
Feb 3, 2023

Conversation

tombruijn
Copy link
Contributor

@tombruijn tombruijn commented Jan 30, 2023

Description

In PR #1604 the Python version was upgraded to Python 3.10 to fix a local issue on M1 MacBooks.

The GitHub Action workflows now exit with the following message for the docker-tests, spellcheck and lint checks, skipping these checks.

lint create: /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  lint: InterpreterNotFound: python3.10
  congratulations :)

Upgrade the Python version in the GitHub Actions workflow to fix this.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running the CI in full

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project

In PR open-telemetry#1604 the Python version was upgraded to Python 3.10 to fix a
local issue on M1 MacBooks.

The GitHub Action workflows now exit with the following message for the
docker-tests, spellcheck and lint checks, skipping these checks.

```
lint create: /home/runner/work/opentelemetry-python-contrib/opentelemetry-python-contrib/.tox/lint
SKIPPED: InterpreterNotFound: python3.10
___________________________________ summary ____________________________________
SKIPPED:  lint: InterpreterNotFound: python3.10
  congratulations :)
```

Upgrade the Python version in the GitHub Actions workflow to fix this.
@tombruijn tombruijn requested a review from a team as a code owner January 30, 2023 08:11
@tombruijn
Copy link
Contributor Author

@ocelotl This seems important to fix the CI build :)

@tombruijn
Copy link
Contributor Author

My bad. In YAML 3.10 != "3.10" and it failed on trying to install Python 3.1.

@tombruijn
Copy link
Contributor Author

Please retry the build :) Should work now 🤞

Upgrade the asyncpg and psycopg2 packages, they don't work on Python
3.10.

This also fixes running these tests no M1 MacBooks.
@tombruijn
Copy link
Contributor Author

Upgraded the dependencies that won't install on Python 3.10. Please retry the build again 😬

Note to self: Don't multi task multiple fixes. I had them already upgraded for another PR I wanted to make, to fix the local build on M1 MacBooks, but turns out it's needed for this PR as well.

@tombruijn
Copy link
Contributor Author

tombruijn commented Jan 30, 2023

The changelog check failure is not something I can do anything about, I think? Does it need the "skip changelog" label?

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 1, 2023
@srikanthccv
Copy link
Member

Please fix the lint

They went unnoticed while the CI didn't fail on the lint task not
working.
@tombruijn
Copy link
Contributor Author

I've fixed the issues that were merged into main. Let's merge this before more issues get merged into main.

I ignored a couple issue flagged pylint because fixing those would actually mean changing the implementation of those methods. You can find them by looking for the # noqa pylint comments in my commit.

@tombruijn
Copy link
Contributor Author

@srikanthccv the build passed! 🎉

@srikanthccv srikanthccv merged commit 78874df into open-telemetry:main Feb 3, 2023
@srikanthccv
Copy link
Member

Thanks @tombruijn

@tombruijn
Copy link
Contributor Author

Thanks for all the help @srikanthccv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants