Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests, fix compliance to semantics #236

Merged
merged 10 commits into from
Dec 10, 2020
Merged

Add more tests, fix compliance to semantics #236

merged 10 commits into from
Dec 10, 2020

Commits on Dec 10, 2020

  1. Update gRPC instrumentation to comply with spec 

    For open-telemetry#139 - some of these things weren't as clear before.
    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    7271cde View commit details
    Browse the repository at this point in the history

  2. Update tests to use proper handler names 

    In the real world, the interceptor is always going to be passed a
HandlerCallDetails object with the `method` field set to something
valid... previously these tests set this to an empty string, but that's
not what happens in a real case.

So I've updated the tests to do that right, but also made sure that the
span processing allows this to be unset, just in case someone was
expecting this behavior to be present.
    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3ca5376 View commit details
    Browse the repository at this point in the history

  3. Check span attributes, fix errors 

    Now checking the span attributes we've added in the Interceptor.

Also fixed some cut & paste errors that resulted in not verifying all
spans as intended.
    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    e70d4b6 View commit details
    Browse the repository at this point in the history

  4. Abort test, clarified attributes 

    Added a test for handling gRPC aborts, which was previously missing.

Updated the `net.*` attributes, so that `net.peer.ip` is always set, and
`net.peer.name` is set only if it's `localhost`, since otherwise we'd
need to do DNS lookups, and the spec doesn't require that.

Added tests to verify the `net.*` shows up properly.
    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8bf21fe View commit details
    Browse the repository at this point in the history

  5. I always forget to run Black on this repo.

    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f3c6083 View commit details
    Browse the repository at this point in the history

  6. Apparently I need to run black twice?

    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    5bd8fad View commit details
    Browse the repository at this point in the history

  7. or more

    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    30b68bf View commit details
    Browse the repository at this point in the history

  8. Format span error description properly

    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    213682e View commit details
    Browse the repository at this point in the history

  9. This is why we now have tests, right? 

    It's really nice to have tests to catch this stuff now.
    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f3abdbc View commit details
    Browse the repository at this point in the history

  10. changelog

    Michael Stella committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    72b58bc View commit details
    Browse the repository at this point in the history