Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sqlalchemy version in sqlalchemy commenter instead of opentelemetry library version #2404

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Use sqlalchemy version in sqlalchemy commenter instead of opentelemetry library version #2404

merged 5 commits into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. Use sqlalchemy version in sqlalchemy commenter instead of opentelemet… 

    …ry library version

The SqlAlchemy commenter is currently using the library version in the comment it emits, e.g.:

```
{
  'db_driver': 'psycopg2', 
  'db_framework': 'sqlalchemy:0.45b0'
}
```

We should instead be using the sqlalchemy version here, as SqlCommenter did before
    @nicknicolini @ocelotl
    nicknicolini authored and ocelotl committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f85a0b5 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @ocelotl
    ocelotl committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0003788 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @ocelotl
    ocelotl committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9954946 View commit details
    Browse the repository at this point in the history

  4. Add CHANGELOG entry

    @ocelotl
    ocelotl committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    25d866f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into patch-1

    @ocelotl
    ocelotl committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2f45948 View commit details
    Browse the repository at this point in the history