Fix ids_generator references from moving from api to sdk #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
requested review from
toumorokoshi and
hectorhdzg
and removed request for
a team
codeboten
approved these changes
Jan 8, 2021
toumorokoshi
approved these changes
Jan 11, 2021
| @@ -18,6 +18,7 @@ | |||
| from opentelemetry import trace as trace_api | |||
| from opentelemetry.exporter.datadog import constants, propagator | |||
| from opentelemetry.sdk import trace | |||
| from opentelemetry.sdk.trace.ids_generator import RandomIdsGenerator | |||
There was a problem hiding this comment.
should we be promoting direct imports from these sub-modules, or just ensuring that all required classes can be imported from the top-level-ish opentelemetry.sdk.trace module?
I feel like it's a bit rigid to import things from opentelemetry.sdk.trace.ids_generator (can't refactor the codebase if you have to split classes / etc).
If you make opentelemetry.sdk.trace a kitchen sink with all of these classes, you not only enable that ability to refactor, but you also reduce the friction on the user having to remember what module some class actually is.
There was a problem hiding this comment.
I agree with you but possibly could be addressed in a later date.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-python#1514