AWS ext depends on SDK IdGenerator #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
requested review from
ocelotl and
lzchen
and removed request for
a team
NathanielRN
force-pushed
the
aws-extension-sdk-dependency
branch
from
d38fabf
to
ea7a32d
Compare
ocelotl
approved these changes
Jul 1, 2021
owais
approved these changes
Jul 1, 2021
codeboten
approved these changes
Jul 6, 2021
andresbeckruiz
pushed a commit
to open-o11y/opentelemetry-python-contrib
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #283 when the
IdGeneratorwas moved from theopentelemetry-apipackage to theopentelemetry-sdkpackage. It makes this extension package take a dependency onopentelemetry-sdkinstead.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.