Implement checking for suppression key in pymongo instrumentation #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for suppression key with pymongo changelog update
ocelotl
approved these changes
Oct 14, 2021
lzchen
reviewed
Oct 14, 2021
lzchen
approved these changes
Oct 14, 2021
nicholasgribanov
pushed a commit
to nicholasgribanov/opentelemetry-python-contrib
that referenced
this pull request
Oct 29, 2021
…en-telemetry#736) * Implement checking for suppression key Add test for suppression key with pymongo changelog update * Linting * pylint * Bad reformat * Update changelog with PR Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #687
Check for suppression key and return early from pymongo monitoring hooks if it is set.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added a test that suppression key results in early return.
test_suppression_keyDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
I don't think any doc needs to be updated.