-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data points in exporter shouldnt use bound instruments #1237
Conversation
b17530e
to
5026b9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several changes in the PR that are not listed in the description. Can you add CHANGELOG entries to otlp, system metrics and sdk packages to explain what is changed?
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Show resolved
Hide resolved
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions I'd like answered before approving
instrumentation/opentelemetry-instrumentation-system-metrics/CHANGELOG.md
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/controller.py
Outdated
Show resolved
Hide resolved
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Show resolved
Hide resolved
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/__init__.py
Outdated
Show resolved
Hide resolved
...ter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/metrics_exporter/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would split this pr up into multiple prs if we are changing more behavior than what is outlined in the current issue.
9a1dca2
to
d9c4da6
Compare
I removed the wrong commits, this PR is as it was before now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If you can create an issue for the last_checkpoint_timestamp
that'd be great.
Co-authored-by: Mayur Kale <mayurkale@google.com>
Fixes #1236
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated
translate_metrics test