-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure Resources follow semantic conventions #1480
Make sure Resources follow semantic conventions #1480
Conversation
Adding default service name population
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on removing a duplicated variable, otherwise it looks good. Were the semantic conventions generated? If not, is this something that would be doable using the generator: https://github.com/open-telemetry/build-tools/tree/master/semantic-conventions?
CONTAINER_IMAGE_NAME = "container.image.name" | ||
CONTAINER_IMAGE_TAG = "container.image.tag" | ||
CONTAINER_NAME = "container.name" | ||
CONTAINER_NAME = "container.name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dup
@@ -38,7 +38,11 @@ def test_resource(self): | |||
def test_resource_empty(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonder if this test should be renamed since it's not using the empty resource (there's a separate create_empty
method for empty resources)
@hectorhdzg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Adding global variables with supported resources
Adding default service name population
Fixes #1477