Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Observed Timestamp #3377

Merged
merged 11 commits into from
Jul 27, 2023
Merged

Conversation

jeremydvoss
Copy link
Contributor

@jeremydvoss jeremydvoss commented Jul 11, 2023

Description

We are supposed to default observed_timestamp to the current timestamp.

Fixes part of #3361

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added tests in sdk and api.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jeremydvoss jeremydvoss marked this pull request as ready for review July 11, 2023 18:51
@jeremydvoss jeremydvoss requested a review from a team as a code owner July 11, 2023 18:51
@jeremydvoss
Copy link
Contributor Author

jeremydvoss commented Jul 13, 2023

Bit confused about this mypy error:
opentelemetry-api/tests/logs/test_log_record.py:28: error: Type of decorated function contains type "Any" ("Callable[..., Any]") Found 1 error in 1 file (checked 37 source files)
Patches need to be passed into tests and the tests are passing fine.

@ocelotl ocelotl self-assigned this Jul 20, 2023
@ocelotl ocelotl enabled auto-merge (squash) July 27, 2023 13:15
@ocelotl ocelotl merged commit b9f31e9 into open-telemetry:main Jul 27, 2023
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants