Export span status to Jaeger

[dgzlopes]

• Sets status tags on the Jaeger span.
• Removes TODO from the Jaeger integration that points to a closed issue with a merged PR.

Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@e9a480f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage          ?   85.26%           
=========================================
  Files             ?       38           
  Lines             ?     1920           
  Branches          ?      225           
=========================================
  Hits              ?     1637           
  Misses            ?      219           
  Partials          ?       64

Impacted Files	Coverage Δ
...-ext-flask/src/opentelemetry/ext/flask/__init__.py	88.88% <100%> (ø)
opentelemetry-api/src/opentelemetry/util/types.py	100% <100%> (ø)
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py	86.54% <100%> (ø)
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py	90.94% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a480f...ae76533. Read the comment docs.

[mauriciovasquezbernal]

I'm wondering if we should try to export the status in some way to Jaeger. Looking at https://github.com/jaegertracing/jaeger-idl/blob/master/thrift/jaeger.thrift it appears to me that there is not any status related field. Perhaps it could be encoded as a tag?

[dgzlopes]

It sounds like a good idea @mauriciovasquezbernal.

From taking a quick look at the Go client, I think that they are doing exactly that.

[mauriciovasquezbernal]

@dgzlopes do you have plans to implement that? If not I'll open an issue to keep track of it.

[dgzlopes]

Sure, I'm happy to implement it @mauriciovasquezbernal. Meanwhile, I'm going to change the title and the status of this pull request.

[dgzlopes]

Also, from taking a closer look at the Go implementation I see that they set an "error" tag in the Jaeger span if Status.Code is not OK. Do you think we should add that tag too?

[codeboten]

Yes! That would be awesome.

[Oberon00]

I think this is something that should be defined in the spec, similar to open-telemetry/opentelemetry-specification#380

[mauriciovasquezbernal]

I opened an issue in the specs repo to track it open-telemetry/opentelemetry-specification#414.

[dgzlopes]

I'm researching why Travis is failing. Locally all the test-ext-jaeger tests are passing.

Update: Now I'm able to reproduce it locally :)

[mauriciovasquezbernal]

It looks good to me, just two small nits.
Thanks!

[dgzlopes]

Fixed nits related with magic numbers on tests :)

[codeboten]

Thanks so much for tackling this. Just one change requested, the rest looks good!

[codeboten]

It might be easier to change _extract_tags to always return an empty list, rather than checking this here

[codeboten]

And in fact we probably should since the only other place where it's used also ends up doing some juggling around this:

opentelemetry-python/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py

Lines 239 to 243 in ed8cbdc

	fields = []
	if event.attributes is not None:
	fields = _extract_tags(event.attributes)
	fields.append(

[dgzlopes]

Fixed! Added the check when span.status wasn't mandatory, but now it makes no sense.

[codeboten]

mind updating the in _extract_logs_from_span as well?

[dgzlopes]

But if we change _extract_logs_from_span to return an empty list when a span has no logs tests break because they expect logs to be None. I think that it's the same with refs.

# Example output form tests
Span([348 chars]Double=None, vBool=None, vLong=None, vBinary=None)], logs=[])
Span([348 chars]Double=None, vBool=None, vLong=None, vBinary=None)], logs=None)

Maybe I'm misunderstanding something. What do you think?

[codeboten]

Sorry, I meant to update the code in _extract_logs_from_span to take advantage of this new empty list from _extract_tags, lines 239 and 240 are no longer needed:

opentelemetry-python/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py

Lines 239 to 243 in ed8cbdc

	fields = []
	if event.attributes is not None:
	fields = _extract_tags(event.attributes)
	fields.append(

[dgzlopes]

Oh, okay! It should be updated now.

[codeboten]

Looks good to me.

[mauriciovasquezbernal]

Thanks for the PR, it looks good to me.
Just pushed a commit to update the changelog for it.