Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: Bump mypy to 0.982 #3776

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix CI: Bump mypy to 0.982 #3776

merged 1 commit into from
Mar 14, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 13, 2024

Description

Fixes broken mypy runs:

.tox/mypy/lib/python3.10/site-packages/deprecated-stubs/classic.pyi:22:
  error: Positional-only parameters are only supported in Python 3.8 and greater

Example of broken run:
https://github.com/open-telemetry/opentelemetry-python/actions/runs/8262935509/job/22603366489?pr=3773

We can bump mypy to newer versions but a lot more errors gets spotted so this is the newest release that works fine with just a couple of updates.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e mypy

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team March 13, 2024 11:38
Fixes broken mypy runs:
.tox/mypy/lib/python3.10/site-packages/deprecated-stubs/classic.pyi:22:
  error: Positional-only parameters are only supported in Python 3.8 and greater
@xrmx xrmx changed the title Bump mypy to 0.982 Fix CI: Bump mypy to 0.982 Mar 14, 2024
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea how hard it would be to fix the new typing issues in this PR?

@lzchen lzchen merged commit 805c1f7 into open-telemetry:main Mar 14, 2024
232 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants