Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-requirements: relax pre-commit version for python 3.8 #3910

Merged
merged 1 commit into from
May 8, 2024
Merged

dev-requirements: relax pre-commit version for python 3.8 #3910

merged 1 commit into from
May 8, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented May 7, 2024

Description

Install 3.5.0 on Python 3.8 as it's done in contrib.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 7, 2024
@xrmx xrmx requested a review from pmcollins May 7, 2024 07:10
@xrmx xrmx requested a review from a team as a code owner May 7, 2024 07:10
@xrmx xrmx mentioned this pull request May 7, 2024
Merged
11 tasks
pmcollins
pmcollins approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for the change.

@ocelotl ocelotl merged commit 5d184d1 into open-telemetry:main May 8, 2024
235 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmcollins pmcollins pmcollins approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @pmcollins @ocelotl