Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint SDK package #65

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Lint SDK package #65

merged 4 commits into from
Jul 26, 2019

Conversation

c24t
Copy link
Member

@c24t c24t commented Jul 26, 2019

Make tox -e lint check the SDK package too.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c24t c24t mentioned this pull request Jul 26, 2019
from typing import Callable
from typing import Optional
from typing import Type
from typing import TypeVar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is uglier than combined imports, but to use isort we need the same style: either single lines or combined everywhere. Without this change isort was failing for other files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually looks better to me.

@c24t c24t merged commit f609450 into open-telemetry:master Jul 26, 2019
@c24t c24t deleted the lint-sdk-too branch July 26, 2019 23:53
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants