Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all instrumentation gems compatible with JRuby #4

Closed
14 tasks
plantfansam opened this issue Jun 6, 2022 · 1 comment
Closed
14 tasks

Make all instrumentation gems compatible with JRuby #4

plantfansam opened this issue Jun 6, 2022 · 1 comment
Labels
good first issue Good for newcomers stale Marks an issue/PR stale

Comments

@plantfansam
Copy link
Contributor

plantfansam commented Jun 6, 2022

We support JRuby on a best effort basis. Unfortunately, some of our instrumentation is not compatible with JRuby. Specifically, the following gems are not compatible:

  • instrumentation-action_pack
  • instrumentation-action_view
  • instrumentation-active_model_serializers
  • instrumentation-active_record
  • instrumentation-active_support
  • instrumentation-aws_sdk
  • instrumentation-delayed_job
  • instrumentation-graphql
  • instrumentation-http
  • instrumentation-http_client
  • instrumentation-koala
  • instrumentation-lmdb
  • instrumentation-rack
  • instrumentation-rails

This ticket will be complete when our CI build successfully runs JRuby specs against every gem in the list above.

To run the specs for a given gem with JRuby in CI, delete the gem from the JRuby filter stanzas (1, 2) in .github/workflows/ci.yml.

Incremental progress against this issue (i.e. fixing one gem at a time!) is very welcome. We will not worry about fixing the gems in one pass!


Note: this ticket came out of #4

@plantfansam plantfansam added the good first issue Good for newcomers label Jun 6, 2022
@plantfansam plantfansam transferred this issue from open-telemetry/opentelemetry-ruby Jun 14, 2022
@github-actions
Copy link
Contributor

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Apr 27, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stale Marks an issue/PR stale
Projects
None yet
Development

No branches or pull requests

1 participant