Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove enable_recognize_route and span_naming options #214

Commits on Nov 30, 2022

  1. fix!: remove enable_recognize_route and span_naming options

    `recognize_route` can end up mutating the request object in the event it
    processes a potential match that is not anchored. That is, shall we say,
    not ideal. (And causes production applications to break).
    
    I was initially going to just default the options to `off`
    (essentially), but why leave potentially dangerous code lying about?
    Also, it ended up being easier to just yank stuff out rather than fix
    the test cases to handle the inverse of what the expected, etc. So, this
    commit just removes it all.
    
    Step backwards in convenience, sure. Big step forward in safety? Definitely.
    
    For context: https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/123/files#r1035711863
    ahayworth committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    24652b6 View commit details
    Browse the repository at this point in the history