chore: Upgrade some Docker dependencies to latest images #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
ahayworth,
plantfansam and
robbkidd
as code owners
arielvalentin
force-pushed
the
docker-file-updates
branch
from
62483cf
to
4263d29
Compare
|
Blocked by trilogy-libraries/trilogy#26 |
arielvalentin
force-pushed
the
docker-file-updates
branch
from
e9ba3b5
to
af180aa
Compare
This commit introduces a few changes to our development docker image: 1. Sets the default Ruby version to 3.1.3 as well as removes the ability to set a custom bundler version and uses the latest gem version 2. Upgrades to mysql 8 since there are no 5.7 images available for Apple Silicon 3. Makes it possible to start up the main service, named `app`, with all of the dependencies to make it possible to run tests in a container 4. Overrides GitHub Action MySQL service to use a different entrypoint script, which is not currently supported via the YAML configurations See open-telemetry#250 See https://stackoverflow.com/questions/60902904/how-to-pass-mysql-native-password-to-mysql-service-in-github-actions See trilogy-libraries/trilogy#26
arielvalentin
force-pushed
the
docker-file-updates
branch
from
465028d
to
1880d68
Compare
arielvalentin
changed the title
robertlaurin
approved these changes
Jan 12, 2023
mwear
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a few changes to our development docker image:
app, with all of the dependencies to make it possible to run tests in a containerSee #250
See https://stackoverflow.com/questions/60902904/how-to-pass-mysql-native-password-to-mysql-service-in-github-actions
See trilogy-libraries/trilogy#26