Use semantic convention for code function label

open-telemetry · Jan 17, 2024 · 03fb66c · 03fb66c
1 parent fec17cf
commit 03fb66c
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/sdk/lib/opentelemetry/sdk/trace/export/batch_span_processor.rb b/sdk/lib/opentelemetry/sdk/trace/export/batch_span_processor.rb
@@ -82,7 +82,7 @@ def on_finish(span)
               n = spans.size + 1 - max_queue_size
               if n.positive?
                 spans.shift(n)
-                report_dropped_spans(n, reason: 'buffer-full', context: 'on_finish')
+                report_dropped_spans(n, reason => 'buffer-full', OpenTelemetry::SemanticConventions::Trace::CODE_FUNCTION => 'on_finish')
               end
               spans << span
               @condition.signal if spans.size > batch_size
@@ -123,7 +123,7 @@ def force_flush(timeout: nil) # rubocop:disable Metrics/MethodLength
               n = spans.size + snapshot.size - max_queue_size
               if n.positive?
                 snapshot.shift(n)
-                report_dropped_spans(n, reason: 'buffer-full', context: 'force_flush')
+                report_dropped_spans(n, reason => 'buffer-full', OpenTelemetry::SemanticConventions::Trace::CODE_FUNCTION => 'force_flush')
               end
               spans.unshift(snapshot) unless snapshot.empty?
               @condition.signal if spans.size > max_queue_size / 2
@@ -204,8 +204,8 @@ def report_result(result_code, batch)
             end
           end
 
-          def report_dropped_spans(count, reason:)
-            @metrics_reporter.add_to_counter('otel.bsp.dropped_spans', increment: count, labels: { 'reason' => reason })
+          def report_dropped_spans(count, labels = {})
+            @metrics_reporter.add_to_counter('otel.bsp.dropped_spans', increment: count, labels: labels)
           end
 
           def fetch_batch