Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource autodetection #230

Closed
mwear opened this issue Apr 23, 2020 · 5 comments · Fixed by #263
Closed

resource autodetection #230

mwear opened this issue Apr 23, 2020 · 5 comments · Fixed by #263
Assignees
@robertlaurin
Milestone
Alpha v0.5

Comments

@mwear
Copy link
Member

mwear commented Apr 23, 2020

It would be nice to have resource auto-detection, similar to what exists in opentelemetry-js. The logic was largely ported from OpenCensus Node:

open-telemetry/opentelemetry-js#899

There is little to no specification for it at this time, there is a related issue:
open-telemetry/opentelemetry-specification#535
@fbogsany
Copy link
Contributor

@robertlaurin can you please comment here so I can assign this one to you? 😄

@robertlaurin
Copy link
Contributor

Hey 👋, I'm going to work on this :)

@fbogsany
Copy link
Contributor

fbogsany commented May 7, 2020

I referenced the OpenTelemetry Collector's implementation of resource auto-discovery on today's SIG call. Turns out it's a little more Kubernetes-specific (and much more complicated) than I thought: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/master/processor/k8sprocessor. I'm not sure how much we can usefully extract from it.

robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue May 14, 2020
@robertlaurin
Add support for automated resource detection
3dc37e4 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
@robertlaurin robertlaurin mentioned this issue May 14, 2020
Merged
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue May 14, 2020
@robertlaurin
Add support for automated resource detection
f390005 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue May 14, 2020
@robertlaurin
Add support for automated resource detection
dba4e58 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue May 14, 2020
@robertlaurin
Add support for automated resource detection
dd8545b 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue May 25, 2020
@robertlaurin
Add support for automated resource detection
2d359bc 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
@mwear mwear added this to the Alpha v0.5 milestone Jun 4, 2020
robertlaurin added a commit to robertlaurin/opentelemetry-ruby that referenced this issue Jun 18, 2020
@robertlaurin
Add support for automated resource detection
1e86b93 
This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For open-telemetry#230
fbogsany pushed a commit that referenced this issue Jun 23, 2020
@robertlaurin
Add support for automated resource detection (#263)
0099668 
* Add support for automated resource detection

This adds support for populating a resource with with Telemetry data
as well as Google Cloud Platform environment metata data.

For #230

* Fix typo typo in correlation context module

* Extract resource detection into a gem

To avoid introducing third party dependencies to the SDK for optional
functionality resource detection has been extracted into its own gem.

* Add resource-detectors README

* Add default Telemetry SDK resource create method

The specification requires a Telemetry::SDK resource, this adds a
method for create it directly from the resource class.  This also
initializes it by default on the configurator.  The resource
setter on the configurator class will merge the default resource
with the one provided.

* Add comment to disable Style/AccessModifierDeclarations in resource class

* Adjust tracer to use instrumentation library

* Re-add tracer_tests for name and version

* Add method documentation, update comments

Add resource documentation for configurator.
Update comments for resource constants.
Simplify resource merging in auto detector.

* Update copyright year, revert incorrect comment

* Fix typo in gcp resource detector test

* Set tracer resource in initializer

* Add tracer_provider reference to tracer

The tracer carries a reference to the tracer_provider that initialized it to
begin supporting multiple tracer providers.
@fbogsany
Copy link
Contributor

Do we consider this fixed by #263 or do we want to leave this open to add resource detection for platforms other than GCP?

@fbogsany fbogsany linked a pull request Jul 8, 2020 that will close this issue
Add support for automated resource detection #263
Merged
@fbogsany
Copy link
Contributor

fbogsany commented Jul 8, 2020

From last week's call, we decided to close this with #263 and open new issues for platforms other than GCP.

@fbogsany fbogsany closed this as completed Jul 8, 2020
This was referenced Jun 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertlaurin robertlaurin

Labels
None yet
Projects
None yet
Milestone
Alpha v0.5
Development

Successfully merging a pull request may close this issue.

Add support for automated resource detection robertlaurin/opentelemetry-ruby
3 participants
@fbogsany @mwear @robertlaurin